please update the tests too - see #1953 for reference
EDIT: oh it's not officially available yet, then it can wait for now

I updated the MSBuild pacakging so that all platforms now use the "net472" resolvers.

@JoeRobich I am not sure I get the change. so it first copies the Mono ref assemblies from global Mono but then overwrites whatever it can from Nuget, correct?

so it first copies the Mono ref assemblies from global Mono but then overwrites whatever it can from Nuget, correct?

@filipw Yes, it is doing the same thing that master is presently doing. I just refactored so that the common steps are more apparent. Since some targets and ref assemblies are needed from Mono's MSBuild, we copy those over first, since they are not in the MSBuild NuGets. We then overwrite with the version of MSBuild we want to ship with from the NuGet. I can update the list of MSBuild runtime targets and props so that we are only copying over what isn't present in the NuGets.

The actual change is that we use the "net472" resolvers on all platforms as RC2 doesn't ship with "netstandard2.0" resolvers.

shall we upgrade Roslyn too?

shall we upgrade Roslyn too?

Sure. Let me see what we are likely shipping in 16.8 Preview 4.

@JoeRobich did I miss more entries in that xml?

@nohwnd You didn't miss anything in this PR. Prior to an OmniSharp release it is nice to bump the Roslyn used by the language services as well. see #1974. In this case I thought I would help out.